Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/lib/eval-config.nix: Add extraModules parameter for opt-in purity #51850

Merged
merged 1 commit into from Aug 24, 2020
Merged

nixos/lib/eval-config.nix: Add extraModules parameter for opt-in purity #51850

merged 1 commit into from Aug 24, 2020

Conversation

roberth
Copy link
Member

@roberth roberth commented Dec 10, 2018 •
edited

Motivation for this change

This allows setting extraModules explicitly, making it possible to invoke NixOS without the NIXOS_EXTRA_MODULE_PATH impurity.

Thanks @ottidmes for discovering this!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date (No mention of eval-config in nixpkgs or nixos manuals. Documentation for NIXOS_EXTRA_MODULE_PATH is still accurate.)
  • Fits CONTRIBUTING.md.

@roberth roberth requested a review from nbp as a code owner December 10, 2018 22:19
@roberth roberth mentioned this pull request Dec 10, 2018
Closed
10 tasks
@danbst
Copy link
Contributor

danbst commented Jan 23, 2019

So, there will be baseModules, modules and extraModules. Quite a fun list!

Maybe better add pure ? false arg? Because extraModules can alwasy be specified by appending extra modules to modules.

cc @ottidmes

@mmahut
Copy link
Member

mmahut commented Aug 18, 2019

Are there any updates on this pull request, please?

@danbst
Copy link
Contributor

danbst commented Aug 18, 2019

cc @nbp for an authoritative review of this small API change.

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
infinisil
infinisil approved these changes Aug 24, 2020
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes a lot of sense to do this. extraModules isn't much different than baseModules or modules internally

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 24, 2020
@infinisil infinisil merged commit b77d8ea into NixOS:master Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@roberth @danbst @mmahut @infinisil @GrahamcOfBorg