Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: zoom-us: 2.5.146186.1130 -> 2.6.146750.1204 #51849

Merged
merged 1 commit into from Dec 18, 2018
Merged

Backport: zoom-us: 2.5.146186.1130 -> 2.6.146750.1204 #51849

merged 1 commit into from Dec 18, 2018

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Dec 10, 2018

(cherry picked from commit 8b3949d)
Backport of #51662

I don't have a stable system where I can test this right now, but the linking looks solid and it works on master. If anyone can give it a go on 18.09 first, all the better. :)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb
zoom-us: 2.5.146186.1130 -> 2.6.146750.1204
80a92d2 
(cherry picked from commit 8b3949d)
Backport of NixOS#51662
@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 18, 2018

Builds and runs on 18.09.1446.db561c90ef3 (Jellyfish)

@c0bw3b c0bw3b merged commit e9a1274 into NixOS:release-18.09 Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srhb @c0bw3b @GrahamcOfBorg