Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wavebox: 4.5.3 -> 4.5.5 #51865

Merged
merged 2 commits into from Dec 11, 2018
Merged

wavebox: 4.5.3 -> 4.5.5 #51865

merged 2 commits into from Dec 11, 2018

Conversation

rawkode
Copy link
Member

@rawkode rawkode commented Dec 11, 2018

Motivation for this change

Updates to latest version (4.5.5) and cleans up the dependencies.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rawkode rawkode changed the title wavebox: Update & Clean Dependencies wavebox: 4.5.3 -> 4.5.5 Dec 11, 2018
@alyssais
Copy link
Member

@GrahamcOfBorg build wavebox

@alyssais alyssais merged commit 1a69b33 into NixOS:master Dec 11, 2018
@worldofpeace
Copy link
Contributor

worldofpeace commented Dec 11, 2018 •
edited

@rawkode If you make another pr in the future please be sure to use correct commit messages.

I can see you corrected your pr title but not the actual commit to wavebox: 4.5.3 -> 4.5.5

@rawkode rawkode deleted the feature/fix-wavebox-deps branch December 11, 2018 14:46
@rawkode
Copy link
Member Author

rawkode commented Dec 11, 2018

Will do, @worldofpeace 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rawkode @alyssais @worldofpeace @GrahamcOfBorg