Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux_testing: 4.20-rc5 -> 4.20-rc6 #51853

Closed
wants to merge 1 commit into from
Closed

linux_testing: 4.20-rc5 -> 4.20-rc6 #51853

wants to merge 1 commit into from

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Dec 10, 2018

Motivation for this change

Tested on XPS 9570 and works fine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fpletz
Copy link
Member

fpletz commented Dec 11, 2018

Thanks! But the update was already pushed to master by @NeQuissimus: c89cbdc

@fpletz fpletz closed this Dec 11, 2018
@NeQuissimus
Copy link
Member

Oh, this is my bad, I am pretty sure I came second. I had not seen this PR.

@eadwu eadwu deleted the linux_testing/4.20-rc6 branch November 17, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eadwu @fpletz @NeQuissimus @GrahamcOfBorg