Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vault: 0.11.5 -> 1.0.0 #51524

Merged
merged 3 commits into from Dec 5, 2018
Merged

vault: 0.11.5 -> 1.0.0 #51524

merged 3 commits into from Dec 5, 2018

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Dec 4, 2018 •
edited

Motivation for this change

HackerNews-driven package upgrade

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thoughtpolice
Copy link
Member

Ofborg is choking on aarch64-linux, though I can't immediately find any recent aarch64-build on Hydra. Is this a regression? Maybe we should just restrict vault to x86/Linux, for now?

@zimbatm
govers: 20150109 -> 20160623
b5360ce
@zimbatm
gox: 0.4.0 -> 20181025
3064dd1 
We need the latest gox to support the latest go releases better.
Unfortunately the author doesn't seem interesting in making new releases
(1y already since the last release).
@zimbatm
vault: 0.11.5 -> 1.0.0
c8091a8
@zimbatm
Copy link
Member Author

zimbatm commented Dec 5, 2018

@GrahamcOfBorg build vault

@zimbatm
Copy link
Member Author

zimbatm commented Dec 5, 2018

looks like upgrading gox was enough to fix the aarch64 build, but now we have a lot of rebuilds

@LnL7
Copy link
Member

LnL7 commented Dec 5, 2018

@GrahamcOfBorg test vault

@zimbatm
Copy link
Member Author

zimbatm commented Dec 5, 2018

only 2k builds, I guess it's ok to go into master

@zimbatm zimbatm merged commit 7faa672 into NixOS:master Dec 5, 2018
@zimbatm zimbatm deleted the vault-1.0.0 branch December 5, 2018 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@rushmorem rushmorem Awaiting requested review from rushmorem

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zimbatm @thoughtpolice @LnL7 @GrahamcOfBorg