Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all-packages.nix: Fix reference to self warning #51525

Merged
merged 1 commit into from Dec 5, 2018
Merged

all-packages.nix: Fix reference to self warning #51525

merged 1 commit into from Dec 5, 2018

Conversation

roberth
Copy link
Member

@roberth roberth commented Dec 4, 2018

This reference was added to master while the deprecation PR #51401 was open.

Motivation for this change

Breaks the tarball derivation which disallows warnings here.

cc @NeQuissimus who wrote the offending line before it was offending.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@roberth
all-packages.nix: Fix reference to self warning
6fcf12e 
This reference was added to master while the deprecation PR NixOS#51401 was open.
@roberth
Copy link
Member Author

roberth commented Dec 4, 2018

@GrahamcOfBorg build slack-dark

@NeQuissimus
Copy link
Member

Oh, my bad!

@NeQuissimus NeQuissimus merged commit 296b333 into NixOS:master Dec 5, 2018
@roberth
Copy link
Member Author

roberth commented Dec 5, 2018

Oh, my bad!

Nope, this was outside your control.

@roberth roberth deleted the fix-all-packages-self-warning branch December 5, 2018 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roberth @NeQuissimus @GrahamcOfBorg