Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos: add AppStream module #51520

Merged
merged 1 commit into from Dec 17, 2018
Merged

nixos: add AppStream module #51520

merged 1 commit into from Dec 17, 2018

Conversation

michaelpj
Copy link
Contributor

Motivation for this change

As suggested in #47173.

Implementation is trivial, just linking some paths. /share/app-info is a little funny, since it contains both collection metadata and icon caches. I'm pretty sure we don't also need to include /share/app-info/icons for that to be merged properly.

@jtojnar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

For references, here is an issue on generating the "Collection metadata" for appstream: #15932

We can probably disable these by default for now. This is all meta information for software that hasn't been installed. They aren't very useful once you have installed the software (you can use .desktop files for that). But eventually we need to index all of these files for GNOME software.

@jtojnar
Copy link
Contributor

jtojnar commented Dec 4, 2018

I agree that we should not need to bother with collections at this time. It will not be really provided by packages anyway,

@michaelpj
Copy link
Contributor Author

Ah, I see. I'd assumed that since it was in a redistributable directory there was some conception of a package providing a collection but it seems not.

I've removed the collection paths.

@jtojnar jtojnar merged commit aacb244 into NixOS:master Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@michaelpj @matthewbauer @jtojnar @worldofpeace @GrahamcOfBorg