Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdenv: Add a fake date utility together with setup #51519

Closed
wants to merge 1 commit into from
Closed

stdenv: Add a fake date utility together with setup #51519

wants to merge 1 commit into from

Conversation

rht
Copy link
Member

@rht rht commented Dec 4, 2018

This is 1 out of the remaining 3 points (fake date in stdenv, numbering names in stdenv, fake time in stdenv) needed to be resolved for #2281.

Based on c232efa.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: stdenv Standard environment label Dec 4, 2018
@rht
Copy link
Member Author

rht commented Dec 4, 2018

Though @alexanderkjeldaas said: #2281 (comment). I suppose this means that there are only 2 points left?

@rht
Copy link
Member Author

rht commented Dec 4, 2018

OK I think I can safely assume that using faketime in itself is sufficient.

@rht rht closed this Dec 4, 2018
@rht rht deleted the fakedate branch December 4, 2018 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
6.topic: stdenv Standard environment 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rht @GrahamcOfBorg