Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos: add XDG sounds module #51518

Merged
merged 1 commit into from Dec 17, 2018
Merged

nixos: add XDG sounds module #51518

merged 1 commit into from Dec 17, 2018

Conversation

michaelpj
Copy link
Contributor

Motivation for this change

As suggested in #47173.

Implementation is trivial: AFAICT there's not much to do other than link the directory.

@jtojnar @worldofpeace (I think you wanted this for the elementary PR)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

Implementation is trivial: AFAICT there's not much to do other than link the directory.

Yeah and it just needs to be in XDG_DATA_DIRS 👍

@michaelpj
Copy link
Contributor Author

Yeah and it just needs to be in XDG_DATA_DIRS

🤦‍♂️ of course

@jtojnar
Copy link
Contributor

jtojnar commented Dec 4, 2018

Yeah and it just needs to be in XDG_DATA_DIRS +1

Which is already ensured by

nixpkgs/nixos/modules/programs/environment.nix

Line 42 in e7ff7b9

XDG_DATA_DIRS = [ "/share" ];

@worldofpeace
Copy link
Contributor

worldofpeace commented Dec 4, 2018 •
edited

I'm testing to see If this resolves things.

Edit: Actually I think my issue was unrelated to this since I was already doing

environment.pathsToLink = [ 
  "/share" 
];

@infinisil
Copy link
Member

Couldn't we just auto-enable this when hardware.sound.enable = true;?

@jtojnar jtojnar merged commit f64bc03 into NixOS:master Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@worldofpeace worldofpeace worldofpeace approved these changes

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@michaelpj @worldofpeace @jtojnar @infinisil @GrahamcOfBorg