Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ntfs-3g: enable extras #51514

Merged
merged 2 commits into from Oct 10, 2019
Merged

ntfs-3g: enable extras #51514

merged 2 commits into from Oct 10, 2019

Conversation

leo60228
Copy link
Member

@leo60228 leo60228 commented Dec 4, 2018

Motivation for this change

Adds a few extra utilities, most of which are useful.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@leo60228
ntfs-3g: enable extras
42cdc11 
Adds a few extra utilities, most of which are useful.
@Mic92
Copy link
Member

Mic92 commented Dec 4, 2018

@GrahamcOfBorg build ntfs-3g

@edolstra
Copy link
Member

edolstra commented Dec 4, 2018

How much size do these extras add?

@leo60228
Copy link
Member Author

leo60228 commented Dec 5, 2018

@edolstra I'd expect barely nothing, it's just a few extra binaries. I'm about to go to sleep, though. ntfs-3g doesn't take long to build if you want to check.

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 5, 2018

Better use httpS for fetching the source archive as:

> http -h http://tuxera.com/opensource/ntfs-3g_ntfsprogs-2017.3.23.tgz
HTTP/1.1 301 Moved Permanently
[...]
Location: https://www.tuxera.com/opensource/ntfs-3g_ntfsprogs-2017.3.23.tgz

Regarding closure size:

# Default derivation without extras
$ nix path-info -sS /nix/store/x6gc02cw99gkgha421c21dv139ac8w5l-ntfs3g-2017.3.23
/nix/store/x6gc02cw99gkgha421c21dv139ac8w5l-ntfs3g-2017.3.23        1320432        67947640

# New derivation with extras
$ nix path-info -sS /nix/store/334ih80dd0ijj4a8vcg09l2hhb5fkgx2-ntfs3g-2017.3.23
/nix/store/334ih80dd0ijj4a8vcg09l2hhb5fkgx2-ntfs3g-2017.3.23        1689952        68317160

@Mic92
Copy link
Member

Mic92 commented Dec 5, 2018 •
edited

so +30% for download and +5% at runtime.

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 5, 2018

@GrahamcOfBorg build ntfs3g

@mmahut
Copy link
Member

mmahut commented Aug 12, 2019

Are there any updates on this pull request, please?

@leo60228
Copy link
Member Author

@mmahut I just pushed a commit downloading over https.

@ofborg ofborg bot requested a review from dezgeg August 12, 2019 12:15
@c0bw3b c0bw3b mentioned this pull request Oct 9, 2019
Closed
10 tasks
@c0bw3b c0bw3b merged commit bb1e6c9 into NixOS:master Oct 10, 2019
srhb pushed a commit to srhb/nixpkgs that referenced this pull request Dec 7, 2019
@leo60228 @srhb
ntfs3g: enable extras (NixOS#51514)
2841de0 
* ntfs-3g: enable extras
Adds a few extra utilities, most of which are useful.

* ntfs-3g: download over https

(cherry picked from commit bb1e6c9)
Backport of NixOS#51514
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@dezgeg dezgeg Awaiting requested review from dezgeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@leo60228 @Mic92 @edolstra @c0bw3b @mmahut @GrahamcOfBorg