Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chicken: 4.13.0 -> 5.0.0 #50341

Merged
merged 1 commit into from Dec 31, 2018
Merged

chicken: 4.13.0 -> 5.0.0 #50341

merged 1 commit into from Dec 31, 2018

Conversation

corngood
Copy link
Contributor

@corngood corngood commented Nov 14, 2018 •
edited

Motivation for this change

WIP because:

  • this is a major breaking update. is it worth keeping both versions, as with python 2/3?
    • no other packages in nixpkgs depend on it
    • build-support/fetchegg and egg2nix had to change for chicken-5, so the changes wouldn't be contained to one directory

chicken 4 and 5 now coexist

  • it still needs more testing

  • I had to update egg2nix for chicken-5, so it's currently fetching my fork until I hear back from upstream

This should be fine as-is for now: the-kenny/egg2nix#3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@corngood corngood force-pushed the chicken-5 branch 2 times, most recently from ed2149b to 875d18a Compare November 14, 2018 03:44
@corngood corngood changed the title WIP: chicken: 4.13.0 -> 5.0.0 chicken: 4.13.0 -> 5.0.0 Dec 27, 2018
@corngood
Copy link
Contributor Author

I ended up letting chicken 4 and 5 coexist, so I've removed WIP. 5 is still the default for the top level packages though.

@infinisil
Copy link
Member

Can you try to eliminate the duplication of package declarations? Similar to python2/3. I'd think only the compilers should differ between 4 and 5, while packages generally can stay compatible with both versions.

@corngood
Copy link
Contributor Author

@infinisil do you mean the generated eggs.nix? The entire ecosystem has been forked for chicken 5, so there's not much that could be done there. Even versioning has been reset for many packages.

I did experiment with abstracting the compiler/hooks/fetch, but it just got ugly.

infinisil
infinisil approved these changes Dec 31, 2018
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah alright, this looks good to me then

@infinisil infinisil merged commit 69ef070 into NixOS:master Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@corngood @infinisil @GrahamcOfBorg