Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/kubernetes: don't enable all alpha feature gates for the kubernetes tests #52365

Merged
merged 1 commit into from Dec 16, 2018
Merged

nixos/kubernetes: don't enable all alpha feature gates for the kubernetes tests #52365

merged 1 commit into from Dec 16, 2018

Conversation

johanot
Copy link
Contributor

@johanot johanot commented Dec 16, 2018

Motivation for this change

Kubernetes alpha features are considered unstable and are less documented, and they might change or be removed at any time. Thus, it causes confusion and sometimes false negatives on the kubernetes test case results to have all alpha features enabled for the test cases only. The module defaults to having alpha features disabled.

In particular and currently, the AllAlpha=true flag causes the tests to break with the v1.13.0 upgrade proposed in #51896, even though all regular features of kubernetes work as expected.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Dec 16, 2018

And this works with the current version in master as well?

@johanot
Copy link
Contributor Author

johanot commented Dec 16, 2018

It does yes. :)

$ git rev-parse HEAD
d2048b0d7edcac82c199c0fb06f0f2359a2bb7ca

$ nix-build ./nixos/release.nix -A tests.kubernetes.rbac.singlenode -A tests.kubernetes.rbac.multinode -A tests.kubernetes.dns.singlenode -A tests.kubernetes.dns.multinode
/nix/store/06w4x1ik0rl8hkc1j6xhw3asg0y7h84f-vm-test-run-kubernetes-rbac-singlenode
/nix/store/idn2r0mslmlbf9mq024383gm66ad1dd7-vm-test-run-kubernetes-rbac-multinode
/nix/store/yqw2vdsf3prhiw59q6xvzwfbydfnfw7w-vm-test-run-kubernetes-dns-singlenode
/nix/store/zwvy7k15p0mfr2c0k1vqi3srmc5qavzz-vm-test-run-kubernetes-dns-multinode

@johanot johanot mentioned this pull request Dec 16, 2018
Merged
10 tasks
@srhb srhb merged commit 78bcfd0 into NixOS:master Dec 16, 2018
@johanot johanot deleted the nixos-kubernetes-disable-alpha-feature-gates branch December 16, 2018 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johanot @srhb @GrahamcOfBorg