Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: Use "buildPackages" darwin for bootstrap_cmd for 18.09 #52252

Merged
merged 2 commits into from Dec 18, 2018
Merged

treewide: Use "buildPackages" darwin for bootstrap_cmd for 18.09 #52252

merged 2 commits into from Dec 18, 2018

Conversation

Ericson2314
Copy link
Member

Motivation for this change

#52251 for 18.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

matthewbauer and others added 2 commits December 15, 2018 12:44
@matthewbauer @Ericson2314
treewide: use "buildPackages" darwin for bootstrap_cmds
dd78e62 
These are almost always from buildPackages. Another issue where
splicing doesn’t seem to pick them up correctly.

(cherry picked from commit 9ab6789)
@Ericson2314
Merge remote-tracking branch 'upstream/release-18.09' into fix-darwin…
1211edb 
…-bootstrap-cmds-for-18.09
@matthewbauer matthewbauer merged commit 2a0f4d2 into NixOS:release-18.09 Dec 18, 2018
@Ericson2314 Ericson2314 deleted the fix-darwin-bootstrap-cmds-for-18.09 branch December 18, 2018 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ericson2314 @matthewbauer @GrahamcOfBorg