fix lldb on macOS #52254
Merged
fix lldb on macOS #52254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to avoid objc errors like:
"_OBJC_CLASS_$_NSDictionary", referenced from:
objc-class-ref in liblldbHost.a(HostInfoMacOSX.mm.o)
objc-class-ref in liblldbPluginPlatformMacOSX.a(PlatformiOSSimulatorCoreSimulatorSupport.mm.o)
ld: symbol(s) not found for architecture x86_64
Fixes NixOS#47886 We don’t want llvm to set the install name for us. It should be the one given to us.
matthewbauer
force-pushed
the
47886-fix
branch
from
c67bd26
to
adcf4aa
Compare
GrahamcOfBorg
added
6.topic: erlang
6.topic: fetch
6.topic: GNOME
GrahamcOfBorg
added
2.status: merge conflict
and removed
6.topic: erlang
6.topic: fetch
6.topic: GNOME
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes #47886
Gets the install_name set correctly for lldb.