Provide real dsymutil to darwin stdenv #52256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were previously using a dummy wrapper for dsymutil. This meant that debug symbols were not getting generated when dsymutil was otherwise available. This should fix that issue & provide a real dsymutil from llvm. Fixes NixOS#52148.
LnL7
reviewed
Dec 15, 2018
| @@ -15,6 +15,7 @@ in | |||
| binutils-unwrapped = callPackage ../os-specific/darwin/binutils { | |||
| inherit (darwin) cctools; | |||
| inherit (pkgs) binutils-unwrapped; | |||
| inherit (pkgs.llvmPackages_5) llvm; | |||
There was a problem hiding this comment.
I'm not sure using an explicit version here is a good idea, it's one more thing to keep in sync when updating the default version.
There was a problem hiding this comment.
For bootstrapping you need it to be llvmPackages_5. Otherwise you would get infinite recursion. I guess we can just rely on llvmPackages = llvmPackages_5 though...
matthewbauer
added a commit
that referenced
this pull request
Dec 30, 2018
These just copy commands from Products/Release/. But with #52256 we now build .dsym directories that somehow wind up in Products/Release/. This makes things more exact by just copying the files in Products/Release/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were previously using a dummy wrapper for dsymutil. This meant that
debug symbols were not getting generated when dsymutil was otherwise
available. This should fix that issue & provide a real dsymutil from
llvm.
Fixes #52148.