Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Encoder interface and derive the encoders/decoders from that interface #2027

Merged
merged 10 commits into from
Dec 15, 2018

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Dec 15, 2018

This is mostly shuffling code around. Things to note:

  • The benchmark is now independent from the encoder and has been rewritten a bit to be less noisy.
  • The parameter null_terminated is at the template level to make sure that the length and the encoding are consistent.

base/base32768.hpp Outdated Show resolved Hide resolved
class Base32768Encoder : public Encoder<char16_t, null_terminated> {
public:
// Encodes |input| into |output|, which must be large enough to hold the
// encoded form.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is identical to the one on the base class, there is no need to repeat it here.

Same below, the comments are not specific to this encoder.

Sorry, something went wrong.

base/base32768.hpp Show resolved Hide resolved
@eggrobin eggrobin added the LGTM label Dec 15, 2018
@pleroy pleroy merged commit 2aba42d into mockingbirdnest:master Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants