Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicacy: init at 2.1.2 #52409

Merged
merged 2 commits into from Mar 22, 2019
Merged

duplicacy: init at 2.1.2 #52409

merged 2 commits into from Mar 22, 2019

Conversation

ffinkdevs
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Mic92
Mic92 requested changes Dec 17, 2018
View reviewed changes
Copy link
Member

@Mic92 Mic92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to. I only left some nitpicks. Could not test the package because of my flacky connectivity.

pkgs/tools/backup/duplicacy/default.nix Outdated Show resolved Hide resolved
pkgs/tools/backup/duplicacy/default.nix Outdated Show resolved Hide resolved
pkgs/tools/backup/duplicacy/default.nix Outdated Show resolved Hide resolved
@Mic92
Copy link
Member

Mic92 commented Dec 17, 2018

@GrahamcOfBorg build duplicacy

@Mic92 @ffinkdevs
Apply suggestions from code review
9e293b3 
Co-Authored-By: ffinkdevs <fink@h0st.space>
@ffinkdevs
Copy link
Contributor Author

@Mic92 you sure its pname when using go packages?, i pretty much just copied restic's derivation and changed it to duplicacy needs

Mic92 added a commit to Mic92/nixpkgs that referenced this pull request Dec 18, 2018
@Mic92
buildGoPackage: also support pname
b4593b4 
Following python-modules and stdenv.mkDerivation.
Hopefully zero rebuilds.

Motivation: NixOS#52409
@Mic92 Mic92 mentioned this pull request Dec 18, 2018
Merged
10 tasks
@Mic92
Copy link
Member

Mic92 commented Dec 18, 2018 •
edited

Indeed this was a limitation of buildGoPackage to not exposing this feature of stdenv. Historically we only had name, which is why most derivations are using it.

@Mic92
Copy link
Member

Mic92 commented Dec 18, 2018

@GrahamcOfBorg eval

@Ralith
Copy link
Contributor

Ralith commented Mar 21, 2019

What's the status of this?

@Mic92 Mic92 merged commit 34bc84d into NixOS:master Mar 22, 2019
@Mic92
Copy link
Member

Mic92 commented Mar 22, 2019

Sorry. I forgot about this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ffinkdevs @Mic92 @Ralith @GrahamcOfBorg @Janik-Haag