Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vim-lsc: init at fe6d3bd and update vim-plugins #52407

Closed
wants to merge 1 commit into from
Closed

vim-lsc: init at fe6d3bd and update vim-plugins #52407

wants to merge 1 commit into from

Conversation

ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Dec 16, 2018

natebosch/vim-lsc is a language server client plugin for vim/neovim. This commit
adds it to the vim-plugin-names file and updates the generated
vim plugins file.

Motivation for this change

vim-lsc is the preferred LSP client for use with the Scala language server metals.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ceedubs
vim-lsc: init at fe6d3bd and update vim-plugins
a90912f 
`natebosch/vim-lsc` is a language server client plugin for vim/neovim.
This commit adds it to the `vim-plugin-names` file and updates the
generated vim plugins file.
ceedubs added a commit to ceedubs/nixpkgs that referenced this pull request Dec 19, 2018
@ceedubs
vim-lsc: init at fe6d3bd
4699d76 
`natebosch/vim-lsc` is a language server client plugin for vim/neovim. This commit
adds it to the `vim-plugin-names` file and the generated vim-plugins
file.

This is a reboot of NixOS#52407 that doesn't call the `update.py` script for
vim plugins, because doing so led to quick merge conflicts. Let me know
if there is a preferred way to do this.
@ceedubs ceedubs mentioned this pull request Dec 19, 2018
Merged
10 tasks
@ceedubs
Copy link
Contributor Author

ceedubs commented Dec 19, 2018

Replaced by #52513

@ceedubs ceedubs closed this Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: vim 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ceedubs @GrahamcOfBorg