Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crosvm: init at 77.0.3865.105 #52352

Merged
merged 2 commits into from Dec 17, 2019
Merged

crosvm: init at 77.0.3865.105 #52352

merged 2 commits into from Dec 17, 2019

Conversation

hyperfekt
Copy link
Contributor

Motivation for this change

crosvm is a virtual machine monitor for KVM, taking a role similar to qemu, but aiming to be much more secure by virtue of omitting the emulation of devices and using a memory-safe programming language as well as isolation of different components via seccomp. It is mostly used on Chromium OS, but not limited to it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member

dtzWill commented Dec 19, 2018

Builds and was able to start running my current kernel (needed to extract vmlinux, even though it says wants bzImage?) which didn't get too far since no devices or disk :D.

@dtzWill
Copy link
Member

dtzWill commented Feb 27, 2019

R73:
dtzWill@5781a82

Although didn't test it beyond building and ensuring the crosvm tool runs.

Is this PR blocking on something? Any reservations about merging?

@hyperfekt
Copy link
Contributor Author

I haven't actually tested it any further than you in December because I got distracted before I could build one with the paravirtualized disk drivers, but in theory (we all know how that goes!) it should work.

@hyperfekt hyperfekt changed the title crosvm: init at R72-11316 crosvm: init at 75 May 15, 2019
@hyperfekt
Copy link
Contributor Author

Updated to version 75. It's now a bit more complex since it has a dependency on a library somewhere else in the Chromium repo and we don't want to check the whole thing out.

@hyperfekt
Copy link
Contributor Author

Before this is merged, I would like for the branch this is based on to turn stable and I would like to figure out how Chromium OS release candidates (tracked here) are turned into actual Chromium OS releases so I can match them.

@aanderse
Copy link
Member

aanderse commented Aug 4, 2019

ping (triage)

@hyperfekt hyperfekt changed the title crosvm: init at 75 crosvm: init at 77.0.3865.105 Oct 27, 2019
@hyperfekt
Copy link
Contributor Author

hyperfekt commented Oct 27, 2019 •
edited

This needs an updater script, some tests, and possibly some optional dependencies added.

EDIT: Update script provided by @alyssais! :D

@hyperfekt hyperfekt force-pushed the init_crosvm branch 3 times, most recently from cfb33af to 4fa1995 Compare October 27, 2019 17:34
@alyssais
Copy link
Member

alyssais commented Oct 29, 2019 via email

@hyperfekt
Copy link
Contributor Author

@alyssais: That was just a function of crosvm requiring KVM (that's the linux part) and it shipping with seccomp policies for these two architectures.

@7c6f434c
Copy link
Member

@hyperfekt the current version is ready for merge, right?

@alyssais is the CrosVM version you test in your SpectrumOS efforts the same as this PR?

@alyssais
Copy link
Member

alyssais commented Dec 16, 2019 via email

@7c6f434c 7c6f434c merged commit e726201 into NixOS:master Dec 17, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Dec 17, 2019
@7c6f434c @dtzWill
Merge pull request NixOS#52352 from hyperfekt/init_crosvm
5547cf0 
crosvm: init at 77.0.3865.105
(cherry picked from commit e726201)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais alyssais left review comments

@JohnAZoidberg JohnAZoidberg JohnAZoidberg left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@hyperfekt @dtzWill @aanderse @alyssais @7c6f434c @JohnAZoidberg @GrahamcOfBorg