Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nextcloud-client: 2.5.0 -> 2.5.1 #52354

Merged
merged 1 commit into from Dec 16, 2018
Merged

nextcloud-client: 2.5.0 -> 2.5.1 #52354

merged 1 commit into from Dec 16, 2018

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Dec 16, 2018

Motivation for this change

Changelog:

Fixup the port in server notification URLs
GUI: let Clang-Tidy modernize nullptr & override usage
Improve the slide show
Libsync: let Clang-Tidy modernize nullptr & override usage 1
SettingsDialog: fix a little glitch in the account tool button size
SettingsDialog: tweak color aware icons
More verbose error and proper app name on configuration read error 1
Fix cmake build using WITH_PROVIDERS=OFF 1
Debian/Ubuntu target repository update 4
Change man page names and contents for nextcloud 1
Share dialog alignment
Fixed typo
Change link to docs for NC 15 1
Do not fetch activities if they are not enabled
Do not read system exclude list if user exclude is present
Fix the activity loop 5
Write the actual folder to the log
Fix appname for Nautilus integration script
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli changed the title Nextcloud client 2.5.1 nextcloud-client: 2.5.0 -> 2.5.1 Dec 16, 2018
@flokli flokli requested a review from Ma27 December 16, 2018 11:48
@flokli flokli mentioned this pull request Dec 16, 2018
Merged
10 tasks
Ma27
Ma27 approved these changes Dec 16, 2018
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

built locally and tested it. Seems fine for me. I'd wait for ofBorg to finish and merge then :)

@Ma27
Copy link
Member

Ma27 commented Dec 16, 2018

hmm it seems as ofborg only tried to build darwin (which is unsupported ATM).

@GrahamcOfBorg build nextcloud-client

@flokli
Copy link
Contributor Author

flokli commented Dec 16, 2018

Nah, that's expected:

Package ‘nextcloud-client-2.5.1’ in /private/var/lib/ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/networking/nextcloud-client/default.nix:39 is not supported on ‘x86_64-apple-darwin’, refusing to evaluate.

@Ma27
Copy link
Member

Ma27 commented Dec 16, 2018

yes, it attempted a darwin build (whichi s unsupported), but the Linux build was missing (it just took longer it seems and now it's built) :)

@Ma27 Ma27 merged commit 18e26e5 into NixOS:master Dec 16, 2018
@Ma27
Copy link
Member

Ma27 commented Dec 16, 2018

@flokli thanks!

@flokli flokli deleted the nextcloud-client-2.5.1 branch December 16, 2018 12:36
@Ma27 Ma27 mentioned this pull request Dec 16, 2018
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flokli @Ma27 @GrahamcOfBorg