Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: circuits/circuits
base: ee60b949d87f^
Choose a base ref
...
head repository: circuits/circuits
compare: 8effbdbff6d5
Choose a head ref
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on Dec 16, 2018

  1. Fix import error

    spaceone committed Dec 16, 2018
    Copy the full SHA
    ee60b94 View commit details
    Browse the repository at this point in the history
  2. Fix circuits.web WSGI components for Python 3

    response.body = str('foobar') in Python3 was not wrapped into a list and
    not encoded into bytes. Therefore WSGI components returned nothing and
    the browser shows a content-type mislength error.
    spaceone committed Dec 16, 2018
    Copy the full SHA
    0d642ea View commit details
    Browse the repository at this point in the history
  3. Fix circuits.web WSGI components for Python 2.7

    Using Controller.redirect() under python 2.7 causes errors due to wrong
    encoding of the Location header value (unicode instead if bytes) (due to
    the "url = request.uri.relative(url).unicode()" call in
    circuits.web.errors.redirect().
    
    HTTP headers seem to be stored as str(), so we ensure str() is returned in items().
    spaceone committed Dec 16, 2018
    Copy the full SHA
    8effbdb View commit details
    Browse the repository at this point in the history