Fluidsynth 1 #52361
Merged
Fluidsynth 1 #52361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csound is incompatible with fluidsynth 2 csound/csound#1078
|
LGTM. @GrahamcOfBorg build csound fluidsynth |
lheckemann
reviewed
Dec 16, 2018
| stdenv.mkDerivation rec { | ||
| name = "fluidsynth-${version}"; | ||
| version = "2.0.1"; |
There was a problem hiding this comment.
Actually, it would be good to leave the fluidsynth 2.x derivation unchanged, thus avoiding a mass-rebuild. You'd just need to add the version line back as version = fluidsynthVersion;.
This avoids a mass-rebuild for packages which depend on fluidsynth 2.x.
|
I've taken the liberty of adding this myself, which means that fluidsynth 2.x's derivation doesn't change at all, which in turn avoids a large number of rebuilds. |
GrahamcOfBorg
added
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
and removed
10.rebuild-darwin: 11-100
10.rebuild-linux: 101-500
labels
GrahamcOfBorg
added
10.rebuild-darwin: 0
10.rebuild-linux: 0
and removed
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
csound needs fluidsynth 1, see csound/csound#1078
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)