Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitlab: 11.5.1 -> 11.5.4 #52386

Merged
merged 3 commits into from Dec 16, 2018
Merged

gitlab: 11.5.1 -> 11.5.4 #52386

merged 3 commits into from Dec 16, 2018

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Dec 16, 2018

Motivation for this change

This bumps gitlab-(ce,ee) from 11.5.1 to 11.5.4, fixing CVE-2018-19856 and CVE-2018-20144

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli added the 9.needs: port to stable A PR needs a backport to the stable release. label Dec 16, 2018
@flokli flokli requested a review from globin December 16, 2018 15:02
@globin
Copy link
Member

globin commented Dec 16, 2018

@GrahamcOfBorg test gitlab

@flokli
Copy link
Contributor Author

flokli commented Dec 16, 2018

@globin @GrahamcOfBorg vm tests still seem to be broken - ran them locally - went through.

Noticed a

gitlab# Both Deployment and its :status machine have defined a different default for "status". Use only one or the other for defining defaults to avoid unexpected behaviors.

warning, not sure if this was there before already or not.

@globin globin merged commit a9eae44 into NixOS:master Dec 16, 2018
@flokli flokli deleted the gitlab-11.5.4 branch December 16, 2018 22:56
@flokli flokli mentioned this pull request Dec 16, 2018
Merged
10 tasks
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
1.severity: security 6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@flokli @globin @samueldr @GrahamcOfBorg