Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.graph-tool: fix build #52261

Merged
merged 1 commit into from Dec 15, 2018
Merged

pythonPackages.graph-tool: fix build #52261

merged 1 commit into from Dec 15, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Dec 15, 2018

Motivation for this change

The new version of cgal introduced in #47826 requires a patch (that will
be included in the next graph-tool version).

Fixes #50446

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
pythonPackages.graph-tool: fix build
96ed553 
The new version of cgal introduced in NixOS#47826 requires a patch (that will
be included in the next graph-tool version).

Fixes NixOS#50446
@timokau timokau requested a review from FRidh as a code owner December 15, 2018 21:51
@timokau
Copy link
Member Author

timokau commented Dec 15, 2018

@GrahamcOfBorg build python3.pkgs.graph-tool

@timokau timokau merged commit 066614a into NixOS:master Dec 15, 2018
@timokau timokau deleted the graph-tool-fix branch December 15, 2018 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timokau @GrahamcOfBorg