Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode-with-extensions: only add flag if extensions > 0 #52298

Merged
merged 1 commit into from Dec 17, 2018
Merged

vscode-with-extensions: only add flag if extensions > 0 #52298

merged 1 commit into from Dec 17, 2018

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented Dec 16, 2018

Motivation for this change

Closes #52073.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hedning
Copy link
Contributor

hedning commented Dec 17, 2018

Looks good, runs without problems.

@hedning hedning merged commit cc1d13a into NixOS:master Dec 17, 2018
@eadwu eadwu mentioned this pull request Dec 19, 2018
Merged
10 tasks
@eadwu eadwu deleted the vscode-with-extensions/empty-extensions-fix branch November 17, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eadwu @hedning @GrahamcOfBorg