Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brave: 0.56.15 -> 0.57.18 #52393

Merged
merged 2 commits into from Dec 19, 2018
Merged

brave: 0.56.15 -> 0.57.18 #52393

merged 2 commits into from Dec 19, 2018

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/brave/versions.

meta.description for brave is: '"Privacy-oriented browser for Desktop and Laptop computers"'.

Checks done (click to expand)
  • built on NixOS
  • Warning: no invocation of /nix/store/snq1m3x769ma3blyqvf1ms1lxmlm3wgk-brave-0.57.18/bin/.brave-wrapped had a zero exit code or showed the expected version
  • Warning: no invocation of /nix/store/snq1m3x769ma3blyqvf1ms1lxmlm3wgk-brave-0.57.18/bin/brave had a zero exit code or showed the expected version
  • 0 of 2 passed binary check by having a zero exit code.
  • 0 of 2 passed binary check by having the new version present in output.
  • found 0.57.18 with grep in /nix/store/snq1m3x769ma3blyqvf1ms1lxmlm3wgk-brave-0.57.18
  • directory tree listing: https://gist.github.com/c729651e6798e262714ce92cd5985b7d
  • du listing: https://gist.github.com/994a42d87b83f0c358dee9c81c922d94
Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
0 i686-linux rebuild(s)
0 x86_64-darwin rebuild(s)
0 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
brave

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/snq1m3x769ma3blyqvf1ms1lxmlm3wgk-brave-0.57.18 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A brave https://github.com/r-ryantm/nixpkgs/archive/0ee9493e6c9cfb69f3cd0eb7e1798813fb8f5eb2.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/snq1m3x769ma3blyqvf1ms1lxmlm3wgk-brave-0.57.18
ls -la /nix/store/snq1m3x769ma3blyqvf1ms1lxmlm3wgk-brave-0.57.18/bin

cc @uskudnik for testing.

@r-ryantm
brave: 0.56.15 -> 0.57.18
0ee9493 
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/brave/versions
@rht
Copy link
Member

rht commented Dec 16, 2018

From the release note at https://github.com/brave/brave-browser/releases/tag/v0.57.18, it seems to be based on 71.0.3578.80, and so the gtk2 dependency can be dropped.

@worldofpeace
Copy link
Contributor

They actually moved from being based on Muon to Chromium this release.
See: https://brave.com/brave-upgrades

@worldofpeace
brave: add at-spi2-core
7941457 
Also correct the style.
@rht
Copy link
Member

rht commented Dec 18, 2018

@worldofpeace that announcement post sounds misleading since earlier they had said the same thing on 0.55 https://brave.com/new-brave-browser-release-available-for-general-download/.

@worldofpeace
Copy link
Contributor

I had to delete ~/.config/BraveSoftware in order execute without a segmentation fault.
I'd like to see if someone who was using this already could reproduce that.

@worldofpeace that announcement post sounds misleading since earlier they had said the same thing on 0.55 https://brave.com/new-brave-browser-release-available-for-general-download/.

Guess they want to keep showing it off 😄

@rht
Copy link
Member

rht commented Dec 18, 2018

(digress) aside from the perf improvement relative to vanilla chrome/chromium, I suppose it would be informative to see how Brave fares with chrome/chromium + uBO: gorhill/uBlock#1279.

@rht
Copy link
Member

rht commented Dec 19, 2018

I was able to run it without segfault, and didn't have to clear the config.

@worldofpeace
Copy link
Contributor

I was able to run it without segfault, and didn't have to clear the config.

In that case I will merge this ❇️

@worldofpeace worldofpeace merged commit e3a931c into NixOS:master Dec 19, 2018
@r-ryantm r-ryantm deleted the auto-update/brave branch December 24, 2018 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@r-ryantm @rht @worldofpeace @GrahamcOfBorg