Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plex: 1.13.9.5456 -> 1.14.0.5470 #51608

Merged
merged 1 commit into from Dec 8, 2018
Merged

plex: 1.13.9.5456 -> 1.14.0.5470 #51608

merged 1 commit into from Dec 8, 2018

Conversation

terraboops
Copy link
Contributor

@terraboops terraboops commented Dec 6, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented Dec 8, 2018

is it intentional that everything lands in /usr/lib in the store path? Or in other words: how can I test whether it still works? :)

@terraboops
Copy link
Contributor Author

Yes, that's how it worked before. I don't know how you can test it without installing / using plex... but I have tested it locally and it works fine 👍

@Ma27
Copy link
Member

Ma27 commented Dec 8, 2018

Tested it now in a simple VM with services.plex.enable = true, so this should be fine.

In the long term we may want to adopt a more intuitive structure in the resulting store path (and maybe stick everything together with buildFHSEnv).

@Ma27 Ma27 merged commit 65b3372 into NixOS:master Dec 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@terraboops @Ma27 @GrahamcOfBorg