octoprint: 1.3.8 -> 1.3.9 #51610
octoprint: 1.3.8 -> 1.3.9 #51610
Conversation
At the same time, clean up how we handle dependencies (shamelessly stolen from home-assistant) and override version constraints.
At the same time: - build plugins against python2 as that is what octoprint uses - do not run checks are there aren't any - use buildPythonPackage as these are not applications
|
@GrahamcOfBorg build python2.pkgs.flask_login python3.pkgs.flask_login |
|
I think flask-login had running tests before. Tests will only be included in the PyPI tarball from the next version on: https://github.com/maxcountryman/flask-login/blob/master/MANIFEST.in#L2. |
|
Thanks for the
I'm very much in favour of simply ignoring the tests for one cycle as it will "fix itself" as you say. |
|
Regarding |
| meta = with stdenv.lib; { | ||
| homepage = https://github.com/OctoPrint/OctoPrint-MQTT; | ||
| description = "Publish printer status MQTT"; | ||
| platforms = platforms.all; |
| }; | ||
| }); | ||
| }; | ||
|
|
||
| py = python2.override { | ||
| packageOverrides = lib.foldr lib.composeExtensions (self: super: { }) ([ |
There was a problem hiding this comment.
I can understand the desire to reduce code duplication, however, this won't always work because we're not always using fetchPypi.
There was a problem hiding this comment.
In case mkOverride can't be used, you can put a function overriding abitrary attributes in the list, e.g.
(self: super: {
pkg = super.pkg.overridePythonAttrs (oldAttrs: {
src = fetchFromGitHub { ... };
});
})
Motivation for this change
Apart from upgrading octoprint, perform a number of cleanups concerning dependencies and constraints.
Cc: @abbradar
Also add octoprint-mqtt.
I haven't actually tried all this out yet (tests pass though) as our printer just arrived y'day.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)