Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.lz4: remove in favor of pythonPackages.python-lz4 #51603

Merged
merged 5 commits into from Dec 25, 2018

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Dec 6, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review pr 51603"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @costrouc

@veprbl
Copy link
Member Author

veprbl commented Dec 6, 2018

@GrahamcOfBorg build mozlz4a python27Packages.buildbot python27Packages.joblib python27Packages.uproot python37Packages.uproot

@FRidh
Copy link
Member

FRidh commented Dec 7, 2018

Why?

@veprbl
Copy link
Member Author

veprbl commented Dec 7, 2018

@FRidh Because right now lz4 is just an outdated version of python-lz4.

@FRidh
Copy link
Member

FRidh commented Dec 7, 2018

Care to document that in the commit message(s).

@veprbl
Copy link
Member Author

veprbl commented Dec 8, 2018

@FRidh done!

lz4 packages the same package as python-lz4, but an outdated version
lz4 used to package the same package as python-lz4, then lz4 was
removed and became an alias to python-lz4
lz4 used to package the same package as python-lz4, then lz4 was
removed and became an alias to python-lz4
@veprbl
Copy link
Member Author

veprbl commented Dec 25, 2018

@GrahamcOfBorg build python2Packages.python-lz4 python3Packages.python-lz4

@veprbl
Copy link
Member Author

veprbl commented Dec 25, 2018

pythonPackages.lz4 was bumped to 2.1.2 in 57aa856 and 775fa99. We still need to get rid of the duplicates.

@veprbl veprbl merged commit 1e1219b into NixOS:master Dec 25, 2018
@veprbl veprbl deleted the pr/drop_python_pkgs_lz4 branch December 1, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants