New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodePackages: Regenerate #51613
nodePackages: Regenerate #51613
Conversation
Can you remove azure-cli? https://www.npmjs.com/package/azure-cli It was deprecated by microsoft and no longer builds. |
Apart from that I have opened tickets for all broken packages. |
I'd also offer to have a look later tonight :) |
All the packages were that I mentioned were also broken before. |
From what I can see the builds for It seems as shortly after the succeeding build most of the node packages have been moved to NodeJS 10 by default (25d6dc9), so I guess it's worth a try building this against Node 8 again (which is IMHO out of scope here though). I'd propose to do the following:
|
I'll check if |
Latest commit moves |
I pushed a commit which marks the remaining to packages as broken, it seems fine for me now.
Yeah, I've seen several tickets requesting the change as well, so I'm optimistic that this issue can be resolved soon. Regarding the package security issues: I agree for transitive dependencies deep inside the dependency tree, but this package doesn't seem to be dead yet and is the top-level package with a locked package set. |
ah great! In that case I'd revert my commit and regenerate the package set (a.k.a resolve the conflicts) |
Regenerates the `nixpkgs` NodeJS set (and updates all dependencies internally). Also, the `azure-cli` package doesn't build with NodeJS 10, so now NodeJS 8 is used for `azure-cli`. Signed-off-by: Maximilian Bosch <maximilian@mbosch.me>
d041ccd
to
6d21e8d
Compare
@the-kenny FYI I rebased your changes onto master (where To make the rebase easier, I squashed both regenerations into one commit and confirmed that it works by running |
@the-kenny thanks! |
Awesome! Thank you all :-) |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)