Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodePackages: Regenerate #51613

Merged
merged 1 commit into from Dec 10, 2018
Merged

Conversation

the-kenny
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Dec 6, 2018

Can you remove azure-cli?

https://www.npmjs.com/package/azure-cli

It was deprecated by microsoft and no longer builds.

@Mic92
Copy link
Member

Mic92 commented Dec 6, 2018

Apart from that I have opened tickets for all broken packages.

@Ma27
Copy link
Member

Ma27 commented Dec 6, 2018

I'd also offer to have a look later tonight :)

@Mic92
Copy link
Member

Mic92 commented Dec 6, 2018

All the packages were that I mentioned were also broken before.

@Ma27
Copy link
Member

Ma27 commented Dec 7, 2018

From what I can see the builds for azure-cli were successful some weeks ago: https://hydra.nixos.org/job/nixos/trunk-combined/nixpkgs.azure-cli.x86_64-linux/all

It seems as shortly after the succeeding build most of the node packages have been moved to NodeJS 10 by default (25d6dc9), so I guess it's worth a try building this against Node 8 again (which is IMHO out of scope here though).

I'd propose to do the following:

  • marking quassel-webserver, meguca and azure-cli as broken and merge this (the rest seems fine).
  • file a new patch (I could do this as well unless one of you wants to take over) where I try to get azure-cli building with NodeJS 8 for now. The package itself is deprecated and should be replaced with a python-based azure-cli in the long term (IIRC some folks wanted to work on this), until then I'd prefer to have at least the old version support as it doesn't seem dead yet (at least as long as we don't have security-related concerns)

@Mic92
Copy link
Member

Mic92 commented Dec 7, 2018

@Ma27 See: #36528 for azure-cli. I don't think we will able to get notified about security issues in our npm package set. That's why I would not include packages that are no longer upstream maintained.

@the-kenny
Copy link
Contributor Author

the-kenny commented Dec 7, 2018

I'll check if azure-cli works fine with node8Packages. Other than that, is there anything blocking this? :-)

@the-kenny
Copy link
Contributor Author

Latest commit moves azure-cli to node--packages-v8.json and regenerates the package set.

@Ma27
Copy link
Member

Ma27 commented Dec 7, 2018

I pushed a commit which marks the remaining to packages as broken, it seems fine for me now.

@Ma27 See: #36528 for azure-cli. I don't think we will able to get notified about security issues in our npm package set. That's why I would not include packages that are no longer upstream maintained.

Yeah, I've seen several tickets requesting the change as well, so I'm optimistic that this issue can be resolved soon. Regarding the package security issues: I agree for transitive dependencies deep inside the dependency tree, but this package doesn't seem to be dead yet and is the top-level package with a locked package set.

@Ma27
Copy link
Member

Ma27 commented Dec 8, 2018

ah great! In that case I'd revert my commit and regenerate the package set (a.k.a resolve the conflicts)

Regenerates the `nixpkgs` NodeJS set (and updates all dependencies
internally).

Also, the `azure-cli` package doesn't build with NodeJS 10, so now
NodeJS 8 is used for `azure-cli`.

Signed-off-by: Maximilian Bosch <maximilian@mbosch.me>
@Ma27
Copy link
Member

Ma27 commented Dec 10, 2018

@the-kenny FYI I rebased your changes onto master (where meguca got fixed and quassel-webserver got removed which resolves all merge conflicts btw).

To make the rebase easier, I squashed both regenerations into one commit and confirmed that it works by running nix-review rev 6d21e8d361157697dfe870f90eddceacecc3e576. I'll wait for ofBorg to evaluate, then this is mergable IMHO.

@Ma27
Copy link
Member

Ma27 commented Dec 10, 2018

@the-kenny thanks!

@the-kenny
Copy link
Contributor Author

Awesome! Thank you all :-)

@the-kenny the-kenny deleted the regenerate-node-packages branch December 10, 2018 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants