Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unit: init at v1.6 #51612

Merged
merged 3 commits into from Dec 8, 2018
Merged

unit: init at v1.6 #51612

merged 3 commits into from Dec 8, 2018

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Dec 6, 2018 •
edited

Motivation for this change

Add dynamic web and application server - nginx unit v1.6

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Dec 7, 2018

@GrahamcOfBorg build unit

grahamc
grahamc reviewed Dec 7, 2018
View reviewed changes
pkgs/servers/http/unit/default.nix
which
python
php71
php72
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it actually need 7.1 and 7.2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each version has its own module. It is possible to easily switch versions

@Izorkin
Copy link
Contributor Author

Izorkin commented Dec 8, 2018

@grahamc update PR, please recheck.

@grahamc
Copy link
Member

grahamc commented Dec 8, 2018

@GrahamcOfBorg build unit

@grahamc grahamc merged commit 3729315 into NixOS:master Dec 8, 2018
@Izorkin
Copy link
Contributor Author

Izorkin commented Dec 8, 2018

Thanks!

@Izorkin Izorkin deleted the nginx-unit branch December 8, 2018 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Izorkin @grahamc @GrahamcOfBorg