Skip to content

cuda 9.2+ supports gcc7 #50041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2018
Merged

cuda 9.2+ supports gcc7 #50041

merged 1 commit into from
Nov 10, 2018
+3 −3

Conversation

jascase901
Copy link
Contributor

@jascase901 jascase901 commented Nov 9, 2018 •
edited
Loading

closes issue #50040

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Nov 9, 2018
@worldofpeace
Copy link
Contributor

@jascase901 Can you reformat the commit msg to something like

cudatoolkit: build versions 9.2+ with gcc7

@jascase901 jascase901 force-pushed the UseGcc7ForNewCudaVersions branch from f59340f to e7379ea Compare November 9, 2018 21:21
@jascase901
Copy link
Contributor Author

@worldofpeace
I did a force push with a new commit message.

@worldofpeace
Copy link
Contributor

cc @abbradar @FRidh (based off of merges and contributions)

@FRidh FRidh merged commit 0b95e5d into NixOS:master Nov 10, 2018
@worldofpeace
Copy link
Contributor

@jascase901 Thanks for correcting this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jascase901 @worldofpeace @FRidh @GrahamcOfBorg