Fixes weird mismatch with libreoffice and libreoffice-unwrapped. #50054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures the package listing shows the expected informations.
samueldr
force-pushed
the
fixes/libreoffice-misc
branch
from
7acb859
to
9695e9f
Compare
libreoffice-unwrapped points to the same libreoffice than libreoffice. libreoffice-*-unwrapped exists for all versions This bring an incompatible change where a user using `libreoffice-unwrapped` hoping to use `fresh` would now be inadvertently be using `still`.
samueldr
force-pushed
the
fixes/libreoffice-misc
branch
from
9695e9f
to
1430f1c
Compare
|
Well, it was a story of «OK will it make the situation better or worse», then ideas to check ran out and I forgot to consider what is the most reasonable layout. And I just forgot about meta, my bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally fixes description on wrapped packages.
Motivation for this change
As far as the attributes are concerned, I believe it's confusing how
libreoffice-unwrappeddoesn't point to the same version thanlibreofficewould (even though it's not really to be used!).I'm not 100% confident on the implementation, is there any reasons for the previous implementation compared to the current implementation? Furthermore, it's more about all the
unwrappedthan specifically libreoffice, but would it make sense to make a move to make them less accessible so new users are less confused by an internal thing? Unless I misunderstood something aboutlibreoffice-*-unwrapped, they are mostly there as an internal thing, right?This bring an incompatible change where a user using
libreoffice-unwrappedhoping to usefreshwould now be inadvertently be usingstill.And for the description, well, that's an obvious net gain, whether the other change is desired or not.
From:
To:
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)cc @7c6f434c as maintainer of libreoffice.