Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github/CODEOWNERS: Add infinisil to NixOS modules #50118

Merged
merged 1 commit into from Nov 10, 2018
Merged

.github/CODEOWNERS: Add infinisil to NixOS modules #50118

merged 1 commit into from Nov 10, 2018

Conversation

infinisil
Copy link
Member

Motivation for this change

I'm often involved with NixOS modules and know a lot about them. Would like to help all PR's that change them.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@samueldr
Copy link
Member

Looks for @infinisil in the changes: 0/0 results.

@7c6f434c
Copy link
Member

@samueldr What did you look for? 35c069e seems to be a relevant non-merge commit, for example.

@infinisil
Copy link
Member Author

Ah yes, some links

These only include ones with the "has: module (update)" label:

My non-trivial NixOS module PR's (manually looked through all my PR's):

I've spent a lot of time diving into the module system internals and know pretty much everything about it too :3.

@dywedir
Copy link
Member

dywedir commented Nov 10, 2018

I think @samueldr meant this:

+ # NixOS modules
+ /nixos/modules
+

@infinisil
Copy link
Member Author

Oh haha, whoops, will fix

@samueldr
Copy link
Member

@7c6f434c just confirming, @dywedir is right, the changes did not initially include infinisil in the CODEOWNERS file.

@Mic92 Mic92 merged commit 565f55c into NixOS:master Nov 10, 2018
@infinisil infinisil deleted the codeowners/infinisil branch April 26, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr samueldr approved these changes

@timokau timokau timokau approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
6.topic: policy discussion 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@infinisil @samueldr @7c6f434c @dywedir @timokau @Mic92 @GrahamcOfBorg