Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustracer: remove rustup dependency #50142

Merged
merged 1 commit into from Nov 10, 2018
Merged

rustracer: remove rustup dependency #50142

merged 1 commit into from Nov 10, 2018

Conversation

danieldk
Copy link
Contributor

Motivation for this change

racer builds fine on Linux and macOS without racer as a dependency.
racer does not actually use rustup, but 'rustc --print sysroot', which
is already available through the rustc dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@danieldk
rustracer: remove rustup dependency
f780a98 
racer builds fine on Linux and macOS without racer as a dependency.
racer does not actually use rustup, but 'rustc --print sysroot', which
is already available through the rustc dependency.
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: rustracer

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/94bnimj4gd4bk8lxvzzzhlq4s4phd13i-racer-2.0.14
shrinking /nix/store/94bnimj4gd4bk8lxvzzzhlq4s4phd13i-racer-2.0.14/bin/racer
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/94bnimj4gd4bk8lxvzzzhlq4s4phd13i-racer-2.0.14/bin
patching script interpreter paths in /nix/store/94bnimj4gd4bk8lxvzzzhlq4s4phd13i-racer-2.0.14
checking for references to /build in /nix/store/94bnimj4gd4bk8lxvzzzhlq4s4phd13i-racer-2.0.14...
/nix/store/94bnimj4gd4bk8lxvzzzhlq4s4phd13i-racer-2.0.14

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rustracer

Partial log (click to expand)


installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/yzpb76ibabsbllkr034hfd207w8i2nv0-racer-2.0.14
shrinking /nix/store/yzpb76ibabsbllkr034hfd207w8i2nv0-racer-2.0.14/bin/racer
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/yzpb76ibabsbllkr034hfd207w8i2nv0-racer-2.0.14/bin
patching script interpreter paths in /nix/store/yzpb76ibabsbllkr034hfd207w8i2nv0-racer-2.0.14
checking for references to /build in /nix/store/yzpb76ibabsbllkr034hfd207w8i2nv0-racer-2.0.14...
/nix/store/yzpb76ibabsbllkr034hfd207w8i2nv0-racer-2.0.14

@timokau timokau merged commit 28d2ab7 into NixOS:master Nov 10, 2018
@danieldk danieldk deleted the racer-no-rustup branch June 4, 2019 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @GrahamcOfBorg @timokau