Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

youtube-dl: 2018.10.29 -> 2018.11.07 #50082

Merged
merged 1 commit into from Nov 10, 2018
Merged

youtube-dl: 2018.10.29 -> 2018.11.07 #50082

merged 1 commit into from Nov 10, 2018

Conversation

va1entin
Copy link
Contributor

@va1entin va1entin commented Nov 9, 2018

Motivation for this change

Download from youtube is broken with the current version in master

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: youtube-dl

Partial log (click to expand)

Successfully installed youtube-dl-2018.11.7
/build/youtube-dl
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/nmvfpfyqxc4y7ivkvqnyaw9nmsnl1170-python3.6-youtube-dl-2018.11.07
gzipping man pages under /nix/store/nmvfpfyqxc4y7ivkvqnyaw9nmsnl1170-python3.6-youtube-dl-2018.11.07/share/man/
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/nmvfpfyqxc4y7ivkvqnyaw9nmsnl1170-python3.6-youtube-dl-2018.11.07/lib  /nix/store/nmvfpfyqxc4y7ivkvqnyaw9nmsnl1170-python3.6-youtube-dl-2018.11.07/bin
patching script interpreter paths in /nix/store/nmvfpfyqxc4y7ivkvqnyaw9nmsnl1170-python3.6-youtube-dl-2018.11.07
checking for references to /build in /nix/store/nmvfpfyqxc4y7ivkvqnyaw9nmsnl1170-python3.6-youtube-dl-2018.11.07...
wrapping `/nix/store/nmvfpfyqxc4y7ivkvqnyaw9nmsnl1170-python3.6-youtube-dl-2018.11.07/bin/youtube-dl'...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: youtube-dl

Partial log (click to expand)

Successfully installed youtube-dl-2018.11.7
/build/youtube-dl
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ks455kqhrl7n8asbygx5wg285p8nzp51-python3.6-youtube-dl-2018.11.07
gzipping man pages under /nix/store/ks455kqhrl7n8asbygx5wg285p8nzp51-python3.6-youtube-dl-2018.11.07/share/man/
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ks455kqhrl7n8asbygx5wg285p8nzp51-python3.6-youtube-dl-2018.11.07/lib  /nix/store/ks455kqhrl7n8asbygx5wg285p8nzp51-python3.6-youtube-dl-2018.11.07/bin
patching script interpreter paths in /nix/store/ks455kqhrl7n8asbygx5wg285p8nzp51-python3.6-youtube-dl-2018.11.07
checking for references to /build in /nix/store/ks455kqhrl7n8asbygx5wg285p8nzp51-python3.6-youtube-dl-2018.11.07...
wrapping `/nix/store/ks455kqhrl7n8asbygx5wg285p8nzp51-python3.6-youtube-dl-2018.11.07/bin/youtube-dl'...

@infinisil
Copy link
Member

@GrahamcOfBorg build youtube-dl

to test the mac build

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: youtube-dl

Partial log (click to expand)

/nix/store/ks455kqhrl7n8asbygx5wg285p8nzp51-python3.6-youtube-dl-2018.11.07

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: youtube-dl

Partial log (click to expand)

/nix/store/nmvfpfyqxc4y7ivkvqnyaw9nmsnl1170-python3.6-youtube-dl-2018.11.07

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: youtube-dl

Partial log (click to expand)

  The script youtube-dl is installed in '/nix/store/8insm1zpahl24iyy3xjmk7dhqaz5hnd8-python3.6-youtube-dl-2018.11.07/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed youtube-dl-2018.11.7
/private/tmp/nix-build-python3.6-youtube-dl-2018.11.07.drv-0/youtube-dl
post-installation fixup
gzipping man pages under /nix/store/8insm1zpahl24iyy3xjmk7dhqaz5hnd8-python3.6-youtube-dl-2018.11.07/share/man/
strip is /nix/store/g5r4apl0za012ffs6ladinwa5w0m1l3k-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/8insm1zpahl24iyy3xjmk7dhqaz5hnd8-python3.6-youtube-dl-2018.11.07/lib  /nix/store/8insm1zpahl24iyy3xjmk7dhqaz5hnd8-python3.6-youtube-dl-2018.11.07/bin
patching script interpreter paths in /nix/store/8insm1zpahl24iyy3xjmk7dhqaz5hnd8-python3.6-youtube-dl-2018.11.07
wrapping `/nix/store/8insm1zpahl24iyy3xjmk7dhqaz5hnd8-python3.6-youtube-dl-2018.11.07/bin/youtube-dl'...

@infinisil infinisil merged commit c74e176 into NixOS:master Nov 10, 2018
@pacien pacien mentioned this pull request Nov 12, 2018
Merged
9 tasks
@va1entin va1entin deleted the youtube-dl_2018.11.07 branch November 16, 2018 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colemickens colemickens colemickens approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@va1entin @GrahamcOfBorg @infinisil @colemickens