Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kdeconnect: 1.3.1 -> 1.3.3 #50070

Merged
merged 1 commit into from Nov 10, 2018
Merged

kdeconnect: 1.3.1 -> 1.3.3 #50070

merged 1 commit into from Nov 10, 2018

Conversation

va1entin
Copy link
Contributor

@va1entin va1entin commented Nov 9, 2018

Motivation for this change

The latest kdeconnect Android app requires at least kdeconnect 1.3.2 for remote file browsing

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@va1entin
Copy link
Contributor Author

va1entin commented Nov 9, 2018

@GrahamcOfBorg build kdeconnect

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: kdeconnect

Partial log (click to expand)

shrinking /nix/store/g0cc5nsbkwiyw3cdfvc1dk2nxqqnjahv-kdeconnect-1.3.3/lib/qt-5.11/plugins/kdeconnect/kdeconnect_ping.so
shrinking /nix/store/g0cc5nsbkwiyw3cdfvc1dk2nxqqnjahv-kdeconnect-1.3.3/lib/qt-5.11/plugins/kf5/kio/kdeconnect.so
shrinking /nix/store/g0cc5nsbkwiyw3cdfvc1dk2nxqqnjahv-kdeconnect-1.3.3/lib/qt-5.11/plugins/kcm_kdeconnect.so
shrinking /nix/store/g0cc5nsbkwiyw3cdfvc1dk2nxqqnjahv-kdeconnect-1.3.3/lib/libkdeconnectcore.so.1.3.3
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/g0cc5nsbkwiyw3cdfvc1dk2nxqqnjahv-kdeconnect-1.3.3/lib  /nix/store/g0cc5nsbkwiyw3cdfvc1dk2nxqqnjahv-kdeconnect-1.3.3/bin
patching script interpreter paths in /nix/store/g0cc5nsbkwiyw3cdfvc1dk2nxqqnjahv-kdeconnect-1.3.3
checking for references to /build in /nix/store/g0cc5nsbkwiyw3cdfvc1dk2nxqqnjahv-kdeconnect-1.3.3...
postPatchMkspecs
postPatchMkspecs

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: kdeconnect

Partial log (click to expand)

shrinking /nix/store/0w545cgi9lbrywhxl661a84aba5jkzvr-kdeconnect-1.3.3/lib/libkdeconnectinterfaces.so.1.3.3
shrinking /nix/store/0w545cgi9lbrywhxl661a84aba5jkzvr-kdeconnect-1.3.3/bin/kdeconnect-indicator
shrinking /nix/store/0w545cgi9lbrywhxl661a84aba5jkzvr-kdeconnect-1.3.3/bin/kdeconnect-handler
shrinking /nix/store/0w545cgi9lbrywhxl661a84aba5jkzvr-kdeconnect-1.3.3/bin/kdeconnect-cli
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0w545cgi9lbrywhxl661a84aba5jkzvr-kdeconnect-1.3.3/lib  /nix/store/0w545cgi9lbrywhxl661a84aba5jkzvr-kdeconnect-1.3.3/bin
patching script interpreter paths in /nix/store/0w545cgi9lbrywhxl661a84aba5jkzvr-kdeconnect-1.3.3
checking for references to /build in /nix/store/0w545cgi9lbrywhxl661a84aba5jkzvr-kdeconnect-1.3.3...
postPatchMkspecs
postPatchMkspecs

@c0bw3b c0bw3b merged commit 3f933cc into NixOS:master Nov 10, 2018
@va1entin va1entin deleted the kdeconnect1.3.3 branch November 16, 2018 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@va1entin @GrahamcOfBorg @c0bw3b