Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openra: adding individual executables for each mod #51404

Merged
merged 1 commit into from Dec 19, 2018
Merged

openra: adding individual executables for each mod #51404

merged 1 commit into from Dec 19, 2018

Conversation

fusion809
Copy link
Contributor

@fusion809 fusion809 commented Dec 2, 2018 •
edited

OpenRA desktop configuration files presently fail to launch the various mods, as the executable files (openra-ra for Red Alert, openra-cnc for Tiberian Dawn and openra-d2k for Dune 2K) they rely on are not present in this package.

Motivation for this change

As previously said the application launchers (i.e. desktop config files) fail to launch the various mods as the executable files they rely upon are not present in PATH (openra-ra, openra-cnc and openra-d2k). This PR creates these executables.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fusion809
openra: adding individual executables for each mod
409d2af 
OpenRA desktop configuration files presently fail to launch the various mods, as the executable files (`openra-ra` for Red Alert, `openra-cnc` for Tiberian Dawn and `openra-d2k` for Dune 2K) they rely on are not present in this package.
@fusion809
Copy link
Contributor Author

@rardiol is the maintainer so probably a good idea to CC him.

@matthewbauer matthewbauer merged commit e261fbe into NixOS:master Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fusion809 @matthewbauer @GrahamcOfBorg