Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jemalloc: add option disable-initial-exec-tls #51376

Merged
merged 2 commits into from Dec 3, 2018
Merged

jemalloc: add option disable-initial-exec-tls #51376

merged 2 commits into from Dec 3, 2018

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Dec 2, 2018 •
edited

Motivation for this change

Add default build option --disable-initial-exec-tls
This option fix error - cannot allocate memory in static TLS block - jemalloc/jemalloc#1237
Need to normal work MariaDB plugin TokuDB

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Izorkin Izorkin changed the base branch from master to staging December 2, 2018 09:15
@Izorkin Izorkin changed the base branch from staging to master December 2, 2018 09:15
@Izorkin Izorkin changed the base branch from master to staging December 2, 2018 09:18
@Mic92
Copy link
Member

Mic92 commented Dec 2, 2018

What is the implication for other applications that work with the current default?

@Izorkin
Copy link
Contributor Author

Izorkin commented Dec 2, 2018

I do not know. How can the parameter be applied only for mariadb?

@Mic92
Copy link
Member

Mic92 commented Dec 2, 2018 •
edited

untested:

mariadb.override ({jemalloc = jemalloc.override({disableInitExecTls = true;};}))

@Izorkin
Copy link
Contributor Author

Izorkin commented Dec 2, 2018

How to add thats variant to pkgs/top-level/all-packages.nix ?

@Izorkin
Copy link
Contributor Author

Izorkin commented Dec 2, 2018

thats?
mariadb = callPackage ../servers/sql/mariadb {
jemalloc = jemalloc.override({disableInitExecTls = true;});
};

Ericson2314
Ericson2314 approved these changes Dec 3, 2018
View reviewed changes
Copy link
Member

@Ericson2314 Ericson2314 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This barely needs staging now, which is good! Can always switch the default of disableInitExecTls later.

@Ericson2314 Ericson2314 merged commit 4112aec into NixOS:staging Dec 3, 2018
@Izorkin Izorkin deleted the jemalloc branch December 3, 2018 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Ericson2314 approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Izorkin @Mic92 @Ericson2314 @GrahamcOfBorg