Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.gateone: needs tornado_4 #51435

Closed
wants to merge 1 commit into from
Closed

pythonPackages.gateone: needs tornado_4 #51435

wants to merge 1 commit into from

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Dec 3, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@manveru manveru requested a review from FRidh as a code owner December 3, 2018 09:18
worldofpeace
worldofpeace suggested changes Dec 3, 2018
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit msg should be pythonPackages.gateone: needs tornado_4

@manveru manveru changed the title gateone: needs tornado_4 pythonPackages.gateone: needs tornado_4 Dec 3, 2018
@manveru
Copy link
Contributor Author

manveru commented Dec 3, 2018

@worldofpeace updated

@FRidh
Copy link
Member

FRidh commented Dec 3, 2018

Python modules are not allowed to rely on a different version of a package in order to prevent multiple versions in an environment.

@worldofpeace
Copy link
Contributor

Python modules are not allowed to rely on a different version of a package in order to prevent multiple versions in an environment.

Please elaborate on what change is needed?
The need for some packages to depend on tornado_4 or tornado is unavoidable.

@manveru
Copy link
Contributor Author

manveru commented Dec 3, 2018

This is actually an executable... Not sure who'd use gateone as a library.

@worldofpeace
Copy link
Contributor

This is actually an executable... Not sure who'd use gateone as a library.

In that case, this should be moved out of python-modules and should use buildPythonApplication instead of buildPythonPackage.

@FRidh
Copy link
Member

FRidh commented Dec 3, 2018

I think this derivation predates the splitting between libraries and applications.

@manveru
Copy link
Contributor Author

manveru commented Dec 3, 2018

Well, I'd appreciate it if someone could do that then, I'm not familiar enough with Python.

@worldofpeace
Copy link
Contributor

worldofpeace commented Dec 3, 2018 •
edited

Well, I'd appreciate it if someone could do that then, I'm not familiar enough with Python.

I can do this for you, I'll push the required changes to this branch in a bit.

@manveru
Copy link
Contributor Author

manveru commented Dec 3, 2018

Thanks :)

tomberek
tomberek approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still functions, thanks for the cleanup @manveru

@worldofpeace
Copy link
Contributor

@tomberek With the NixOS service?

@tomberek
Copy link
Contributor

tomberek commented Dec 6, 2018

@worldofpeace : Non-NixOS worked fine when just running the package. Ran into issues with the service on NixOS:

  1. The pidDir is not created.
  2. After that was resolved, the service error-ed with the following:
systemd[1]: Starting GateOne web-based terminal...
systemd[1]: Started GateOne web-based terminal.
gateone[15438]: Traceback (most recent call last):
gateone[15438]:   File "/nix/store/mi80nhj95lpxzh92wr7imzvwwfkcch5q-python2.7-gateone-1.2-0d57c3/bin/.gateone-wrapped", line 8, in <module>
gateone[15438]:     from gateone.core.server import main
gateone[15438]:   File "/nix/store/mi80nhj95lpxzh92wr7imzvwwfkcch5q-python2.7-gateone-1.2-0d57c3/lib/python2.7/site-packages/gateone/core/server.py", line 402, in <module>
gateone[15438]:     from gateone.auth.authorization import require, authenticated, policies
gateone[15438]:   File "/nix/store/mi80nhj95lpxzh92wr7imzvwwfkcch5q-python2.7-gateone-1.2-0d57c3/lib/python2.7/site-packages/gateone/auth/authorization.py", line 38, in <module>
gateone[15438]:     @memoize
gateone[15438]:   File "/nix/store/mi80nhj95lpxzh92wr7imzvwwfkcch5q-python2.7-gateone-1.2-0d57c3/lib/python2.7/site-packages/gateone/core/utils.py", line 290, in __init__
gateone[15438]:     MEMO = AutoExpireDict(timeout=timeout, interval="30s")
gateone[15438]:   File "/nix/store/mi80nhj95lpxzh92wr7imzvwwfkcch5q-python2.7-gateone-1.2-0d57c3/lib/python2.7/site-packages/gateone/core/utils.py", line 161, in __init__
gateone[15438]:     self.interval = kwargs.pop('interval')
gateone[15438]:   File "/nix/store/mi80nhj95lpxzh92wr7imzvwwfkcch5q-python2.7-gateone-1.2-0d57c3/lib/python2.7/site-packages/gateone/core/utils.py", line 211, in interval
gateone[15438]:     self._timeout_checker, value, io_loop=self.io_loop)
gateone[15438]: TypeError: __init__() got an unexpected keyword argument 'io_loop'
gateone[15438]: Exception AttributeError: "'AutoExpireDict' object has no attribute '_key_watcher'" in <bound method AutoExpireDict.__del__ of {}> ignored
systemd[1]: gateone.service: Main process exited, code=exited, status=1/FAILURE
systemd[1]: gateone.service: Failed with result 'exit-code'.

@mmahut
Copy link
Member

mmahut commented Aug 12, 2019

Are there any updates on this pull request, please?

@manveru
Copy link
Contributor Author

manveru commented Nov 29, 2019

Since this seems to be outdated, and I'm not planning on using this package. I'll close it.

@manveru manveru closed this Nov 29, 2019
@tomberek
Copy link
Contributor

Should we mark as broken?

@manveru manveru deleted the fix-gateone branch December 12, 2019 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

@tomberek tomberek tomberek approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 6.topic: python 8.has: clean-up 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@manveru @FRidh @worldofpeace @tomberek @mmahut @GrahamcOfBorg