Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nss: 3.40 -> 3.40.1 #51365

Merged
merged 2 commits into from Dec 3, 2018
Merged

nss: 3.40 -> 3.40.1 #51365

merged 2 commits into from Dec 3, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 2, 2018

Motivation for this change

https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/NSS_3.40.1_release_notes#New_in_NSS_3.40.1

No new functionality is introduced in this release. This is a patch release to fix CVE-2018-12404

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Dec 3, 2018

Backport? Not sure what versions are impacted... not sure how to flag this to be sure it's in the next roundup (or just handled directly). cc @grahamc ? :)

@dtzWill dtzWill merged commit fb137c1 into NixOS:staging Dec 3, 2018
@dtzWill dtzWill deleted the update/nss-3.40.1 branch December 3, 2018 07:05
@andir
Copy link
Member

andir commented Dec 11, 2018

@dtzWill This should also be backported as firefox34 (scheduled for tomorrow) has it as requirement. Let me know if you have time to do that otherwise I'll try to get it done in the evening.

vcunat pushed a commit that referenced this pull request Dec 12, 2018
(cherry picked from commit fb137c1)
This is a patch release to fix CVE-2018-12404.
@vcunat
Copy link
Member

vcunat commented Dec 12, 2018

Staged as ea9cfed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants