Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mlt: 6.10.0 -> 6.12.0 #51370

Closed
wants to merge 4 commits into from
Closed

mlt: 6.10.0 -> 6.12.0 #51370

wants to merge 4 commits into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Dec 2, 2018

Motivation for this change

https://github.com/mltframework/mlt/releases/tag/v6.12.0

Notes mention new VA-API support, and other goodies..
among many important fixes! :)

Should look through them more closely,
possibly adding new deps (for vaapi?).

(note to myself but open to anyone with a second :))

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill mentioned this pull request Dec 16, 2018
Closed
c0bw3b
c0bw3b reviewed Dec 19, 2018
View reviewed changes
pkgs/development/libraries/mlt/default.nix

src = fetchFromGitHub {
owner = "mltframework";
repo = "mlt";
rev = "v${version}";
sha256 = "0ki86yslr5ywa6sz8pjrgd9a4rn2rr4mss2zkmqi7pq8prgsm1fr";
sha256 = "0pzm3mjbbdl2rkbswgyfkx552xlxh2qrwzsi2a4dicfr92rfgq6w";
};

buildInputs = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least makeWrapper and pkgconfig should be into nativeBuildInputs

@c0bw3b
Copy link
Contributor

c0bw3b commented Dec 19, 2018

The configure flag --enable-gpl is repeated twice?

@dtzWill
Copy link
Member Author

dtzWill commented Feb 12, 2019

The configure flag --enable-gpl is repeated twice?

That's how you enable gpl x2 => gplv2 code, right?! 🤣

Cleaning up, thank you for review and apologies for missing these things!
Oh hooray: in my defense the configureArgs were already dup'd haha.
Okay I'll check they don't somehow actually help xD.

@dtzWill
Copy link
Member Author

dtzWill commented Feb 12, 2019

Seems we half-upgraded this by bumping qt-enabled variant in b0f912b or so. Rebasing/fixing underway...

@dtzWill
mlt: combine mlt-qt5 with mlt
00098d8
@dtzWill
mlt: opencv explicitly, add deps SDL2, libexif to enable more
bce556c 
* needs 'which' to find bins from ladspa-sdk, add
* cleanup a bit, qt seems fine as-is (?)
@dtzWill
Copy link
Member Author

dtzWill commented Feb 12, 2019

Merged the two mlt expressions, which seems high-level good (as well as a few dependencies that seem no heavier than what's already pulled in) but should make sure shotcut and kdenlive both still work. I nuked the "fix motiv.dev" postInstall as likely kruft but will revisit.

@c0bw3b c0bw3b mentioned this pull request May 12, 2019
Closed
@dtzWill
Copy link
Member Author

dtzWill commented May 31, 2019

This seems to have suffered some bitrot, if we have a better PR or so feel free to close :). Hopefully will be revisited eventually if not :).

@stale
Copy link

stale bot commented Jun 2, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@SuperSandro2000
Copy link
Member

Master already has version 6.22.1. If you want to move any of the other changes over please open a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b left review comments

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees
No one assigned
Labels
2.status: merge conflict 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dtzWill @c0bw3b @SuperSandro2000 @ryantm @infinisil @GrahamcOfBorg