Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vault: 0.11.2 -> 0.11.5 #51417

Merged
merged 1 commit into from Dec 4, 2018
Merged

vault: 0.11.2 -> 0.11.5 #51417

merged 1 commit into from Dec 4, 2018

Conversation

jvassev
Copy link
Contributor

@jvassev jvassev commented Dec 2, 2018 •
edited

Motivation for this change

Update bash completion method as described in
https://www.vaultproject.io/docs/commands/#autocompletion

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Dec 3, 2018

@GrahamcOfBorg build nixosTests.vault

@Mic92 Mic92 merged commit bf90c31 into NixOS:master Dec 4, 2018
@Mic92
Copy link
Member

Mic92 commented Dec 4, 2018

Thanks!

@jvassev jvassev deleted the vault branch December 4, 2018 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jvassev @Mic92 @GrahamcOfBorg @Janik-Haag