gnumake: disable subsecond mtime on darwin #51408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamcOfBorg
added
6.topic: darwin
|
Can you add a comment in the code? I can imagine someone discovering files not being rebuilt in one of their builds (the dual of our issue with |
Mic92
reviewed
Dec 2, 2018
| @@ -27,7 +27,8 @@ stdenv.mkDerivation { | |||
| nativeBuildInputs = stdenv.lib.optionals guileSupport [ pkgconfig ]; | |||
| buildInputs = stdenv.lib.optionals guileSupport [ guile ]; | |||
|
|
|||
| configureFlags = stdenv.lib.optional guileSupport "--with-guile"; | |||
| configureFlags = stdenv.lib.optional guileSupport "--with-guile" | |||
| ++ stdenv.lib.optional stdenv.isDarwin "ac_cv_struct_st_mtim_nsec=no"; | |||
There was a problem hiding this comment.
Should this maybe carry a comment, when it should safe to re-enable this feature again?
i.e. a while after 10.13?
matthewbauer
force-pushed
the
disable-subsecond-gnumake
branch
from
c0fde56
to
5d31221
Compare
endgame
approved these changes
Dec 3, 2018
gnumake can support subsecond mtimes if it is available. But Darwin doesn’t support setting subsecond mtimes until 10.13! So we can just disable this check to avoid the issue where most of our built tools use seconds but make uses nanoseconds. Might fix some parallel issues along the way. Fixes NixOS#51221
matthewbauer
force-pushed
the
disable-subsecond-gnumake
branch
from
5d31221
to
26de2d1
Compare
wolfgangwalther
added a commit
to wolfgangwalther/nixpkgs
that referenced
this pull request
Mar 7, 2024
This was disabled to fix NixOS#51093. The related discussion upstream revealed that this has been fixed in [1] for v12+. Since v12 is our oldest supported version right now, we should be able to safely enable parallel building on darwin again. Furthermore, it seems that this kind of issue was also fixed in NixOS#51221 and NixOS#51408 for the general case. [1]: postgres/postgres@826eff5
wolfgangwalther
added a commit
to wolfgangwalther/nixpkgs
that referenced
this pull request
Mar 7, 2024
This was disabled to fix NixOS#51093. The related discussion upstream revealed that this has been fixed in [1] for v12+. Since v12 is our oldest supported version right now, we should be able to safely enable parallel building on darwin again. Furthermore, it seems that this kind of issue was also fixed in NixOS#51221 and NixOS#51408 for the general case. [1]: postgres/postgres@826eff5
wolfgangwalther
added a commit
to wolfgangwalther/nixpkgs
that referenced
this pull request
Mar 8, 2024
This was disabled to fix NixOS#51093. The related discussion upstream revealed that this has been fixed in [1] for v12+. Since v12 is our oldest supported version right now, we should be able to safely enable parallel building on darwin again. Furthermore, it seems that this kind of issue was also fixed in NixOS#51221 and NixOS#51408 for the general case. [1]: postgres/postgres@826eff5
wolfgangwalther
added a commit
to wolfgangwalther/nixpkgs
that referenced
this pull request
Mar 9, 2024
This was disabled to fix NixOS#51093. The related discussion upstream revealed that this has been fixed in [1] for v12+. Since v12 is our oldest supported version right now, we should be able to safely enable parallel building on darwin again. Furthermore, it seems that this kind of issue was also fixed in NixOS#51221 and NixOS#51408 for the general case. [1]: postgres/postgres@826eff5
wolfgangwalther
added a commit
to wolfgangwalther/nixpkgs
that referenced
this pull request
Mar 16, 2024
This was disabled to fix NixOS#51093. The related discussion upstream revealed that this has been fixed in [1] for v12+. Since v12 is our oldest supported version right now, we should be able to safely enable parallel building on darwin again. Furthermore, it seems that this kind of issue was also fixed in NixOS#51221 and NixOS#51408 for the general case. [1]: postgres/postgres@826eff5
wolfgangwalther
added a commit
to wolfgangwalther/nixpkgs
that referenced
this pull request
Mar 17, 2024
This was disabled to fix NixOS#51093. The related discussion upstream revealed that this has been fixed in [1] for v12+. Since v12 is our oldest supported version right now, we should be able to safely enable parallel building on darwin again. Furthermore, it seems that this kind of issue was also fixed in NixOS#51221 and NixOS#51408 for the general case. [1]: postgres/postgres@826eff5
wolfgangwalther
added a commit
to wolfgangwalther/nixpkgs
that referenced
this pull request
Mar 17, 2024
This was disabled to fix NixOS#51093. The related discussion upstream revealed that this has been fixed in [1] for v12+. Since v12 is our oldest supported version right now, we should be able to safely enable parallel building on darwin again. Furthermore, it seems that this kind of issue was also fixed in NixOS#51221 and NixOS#51408 for the general case. [1]: postgres/postgres@826eff5
wolfgangwalther
added a commit
to wolfgangwalther/nixpkgs
that referenced
this pull request
Apr 3, 2024
This was disabled to fix NixOS#51093. The related discussion upstream revealed that this has been fixed in [1] for v12+. Since v12 is our oldest supported version right now, we should be able to safely enable parallel building on darwin again. Furthermore, it seems that this kind of issue was also fixed in NixOS#51221 and NixOS#51408 for the general case. [1]: postgres/postgres@826eff5
wolfgangwalther
added a commit
to wolfgangwalther/nixpkgs
that referenced
this pull request
Apr 4, 2024
This was disabled to fix NixOS#51093. The related discussion upstream revealed that this has been fixed in [1] for v12+. Since v12 is our oldest supported version right now, we should be able to safely enable parallel building on darwin again. Furthermore, it seems that this kind of issue was also fixed in NixOS#51221 and NixOS#51408 for the general case. [1]: postgres/postgres@826eff5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gnumake can support subsecond mtimes if it is available. But Darwin
doesn’t support setting subsecond mtimes until 10.13! So we can just
disable this check to avoid the issue where most of our built tools
use seconds but make uses nanoseconds. Might fix some parallel issues
along the way.
Fixes #51221
/cc @endgame @delroth @thoughtpolice