Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/containers: Add assertion for container name length #51393

Merged
merged 1 commit into from Dec 5, 2018
Merged

nixos/containers: Add assertion for container name length #51393

merged 1 commit into from Dec 5, 2018

Conversation

arianvp
Copy link
Member

@arianvp arianvp commented Dec 2, 2018

Fixes #38509

Motivation for this change

When privateNetwork is enabled, currently the container's interface name
is derived from the container name. However, there's a hard limit
on the size of interface names. To avoid conflicts and other issues,
we set a limit on the container name when privateNetwork is enabled.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@arianvp
nixos/containers: Add assertion for container name length
bf10282 
When privateNetwork is enabled, currently the container's interface name
is derived from the container name. However, there's a hard limit
on the size of interface names. To avoid conflicts and other issues,
we set a limit on the container name when privateNetwork is enabled.

Fixes NixOS#38509
@Mic92
Copy link
Member

Mic92 commented Dec 2, 2018

@GrahamcOfBorg build nixosTests.containers-bridge

@flokli flokli merged commit 0834e98 into NixOS:master Dec 5, 2018
@flokli
Copy link
Contributor

flokli commented Dec 5, 2018

@arianvp do you want to backport this to 18.09 as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arianvp @Mic92 @flokli @GrahamcOfBorg