Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodejs.updateScript, thunderbird.updateScript: fix evaluation #51421

Merged
merged 2 commits into from Dec 3, 2018
Merged

nodejs.updateScript, thunderbird.updateScript: fix evaluation #51421

merged 2 commits into from Dec 3, 2018

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Dec 3, 2018 •
edited

Motivation for this change

They no longer evaluate after #50977; it makes the tarball job unhappy.

/cc @jtojnar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.
  • $ nix-build nixos/release-small.nix -A nixpkgs.tarball

@jtojnar jtojnar merged commit 3008c2a into NixOS:master Dec 3, 2018
@jtojnar
Copy link
Contributor

jtojnar commented Dec 3, 2018

Thank you

@pbogdan pbogdan deleted the update-scripts-eval branch December 3, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pbogdan @jtojnar @GrahamcOfBorg