Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/cockroachdb: supply defaultText for the package option #51409

Merged
merged 1 commit into from Dec 3, 2018
Merged

nixos/cockroachdb: supply defaultText for the package option #51409

merged 1 commit into from Dec 3, 2018

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Dec 2, 2018

Motivation for this change

This was preventing evaluating the NixOS manual on platforms not supported by cockroachdb package itself:

Package ‘cockroach-2.1.1’ in /home/pbogdan/nixpkgs/pkgs/servers/sql/cockroachdb/default.nix:59 is not supported on ‘i686-unknown-linux-gnu’, refusing to evaluate.

Notably this currently prevents the tested Hydra job from evaluating as the manual is one of the constituents.

https://hydra.nixos.org/jobset/nixos/trunk-combined#tabs-errors -> CTRL-F "in job ‘tested’:"

/cc @thoughtpolice

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Dec 2, 2018

@GrahamcOfBorg eval

@thoughtpolice thoughtpolice merged commit 9ca3414 into NixOS:master Dec 3, 2018
@thoughtpolice
Copy link
Member

Thanks for the catch. Sorry about that @pbogdan

@pbogdan pbogdan deleted the crdb-def-text branch December 3, 2019 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants