Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport mumble fix #51361

Merged
merged 1 commit into from Dec 2, 2018
Merged

Backport mumble fix #51361

merged 1 commit into from Dec 2, 2018

Conversation

davidak
Copy link
Member

@davidak davidak commented Dec 2, 2018 •
edited

Motivation for this change

Fixes #51196

I have cherry-picked 1 commit from master that fixes the problem.

This is my first backport PR, so please review extra thorough.

cc maintainers @jgeerds @wkennington

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace added the 8.has: port to stable A PR already has a backport to the stable release. label Dec 2, 2018
@thefloweringash @davidak
mumble: fix hang on reconfiguring audio
65b2552 
(cherry picked from commit 773c880)

Reason: Backport fix to 18.09
@Mic92
Copy link
Member

Mic92 commented Dec 2, 2018

@GrahamcOfBorg build mumble

@Mic92 Mic92 mentioned this pull request Dec 2, 2018
Closed
@Mic92 Mic92 merged commit 6c6aef8 into NixOS:release-18.09 Dec 2, 2018
@davidak davidak deleted the fix-mumble branch December 3, 2018 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@davidak @Mic92 @GrahamcOfBorg @worldofpeace @thefloweringash