Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrcpy: 1.3 -> 1.5 #51427

Merged
merged 1 commit into from Dec 7, 2018
Merged

scrcpy: 1.3 -> 1.5 #51427

merged 1 commit into from Dec 7, 2018

Conversation

tomberek
Copy link
Contributor

@tomberek tomberek commented Dec 3, 2018

Motivation for this change

Update to newest version

Things done

Updated version.
Added configurations to allow hardware and software rendering.
Added configuration to remove unneeded errors.
Added configuration to use prebuilt server directly.
Tested on Ubuntu, NixOS.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add comments with the explanations you've given to @Mic92?

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build scrcpy

@worldofpeace
Copy link
Contributor

Shouldn't we be at this version?

@tomberek
Copy link
Contributor Author

tomberek commented Dec 6, 2018

@worldofpeace good catch!

@worldofpeace
Copy link
Contributor

@tomberek Thanks for this ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants