dsniff: init at 2.4b1 #51418
Merged
dsniff: init at 2.4b1 #51418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7c6f434c
reviewed
Dec 3, 2018
| rm $out/lib/*.so* | ||
| ''; | ||
| }; | ||
| pcap = symlinkJoin { |
There was a problem hiding this comment.
Is it worth it to do all the symlink dance instead of just force-passing an extra -I and biting the relatively small closure bloat?
There was a problem hiding this comment.
The compiler finds libraries just fine, it is the configure script which does strange things by looking at the actual files instead of deferring finding libraries to the compiler.
|
I consider the minor pain that is this package justified by the upstream supply of pain in the build system (and having dsniff around is useful) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I wanted to use tcpkill
Things done
upstream does not provide a stable url. So I used debian as source. This enables me to use their 36 patches to have dsniff build with recent version of libraries like openssl. Debian only provides the beta version, like most distros according to repology. This is probably because dsniff is not much maintained. If you think we should not add dsniff to nixpkgs for this reason, I'd understand. I do this PR mainly because I spent time on it, so I'd like to share :)
Their build system demands static libraries and header files under the same prefix. So I have to override all libraries and merge their outputs. In the end, there is still a reference to openssl for
/nix/store/a23xvnnl29scqqjvcqya6vgs0vnz1shi-openssl-1.1.1/etc/ssl/ct_log_list.cnfso dsniff will depend on openssl dev output... This is very sad.sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"Tested execution of all binary files (usually inonly tcpkill./result/bin/)nix path-info -Sbefore and after)